Implement new flag --pause-reconciliation#11
Merged
Conversation
added 2 commits
December 4, 2025 14:38
mclasmeier
changed the title
vikin91
reviewed
Dec 4, 2025
vikin91
reviewed
Dec 4, 2025
vikin91
reviewed
Dec 4, 2025
vikin91
left a comment
vikin91
left a comment
There was a problem hiding this comment.
The idea looks good, but I am not proficient in this codebase to do a proper review.
However, I can test it and let you know how it works in the practice (I haven't done this yet).
Collaborator
Author
|
@vikin91 Got it, this was mostly meant as an FYI with the option for you to also review the change. |
porridge
approved these changes
Dec 8, 2025
Contributor
porridge
left a comment
porridge
left a comment
There was a problem hiding this comment.
LGTM modulo a few inline nitpicks
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
mclasmeier
force-pushed
the
mc/pause-reconciliation
branch
from
1e5bdac to
1759e40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the use-case where you want to freely fiddle around with created resources on the cluster without any reconciliation getting in the way.